content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: Pass FDs & Regions through to child process (Still has formatting errors) Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/app/ChildProcessService.java ('k') | content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java » ('j') | gin/v8_initializer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java

index 5e57838551d927b8572a92523b4574d85db42b88..0e0071c7fcf8292ac31e7c5fd63171d1f843d2d6 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java

@@ -40,10 +40,8 @@ public interface ChildProcessConnection {

public static final String EXTRA_COMMAND_LINE =

"com.google.android.apps.chrome.extra.command_line";

// Note the FDs may only be passed in the connection bundle.

- public static final String EXTRA_FILES_PREFIX =

- "com.google.android.apps.chrome.extra.extraFile_";

- public static final String EXTRA_FILES_ID_SUFFIX = "_id";

- public static final String EXTRA_FILES_FD_SUFFIX = "_fd";

+ public static final String EXTRA_FILES =

+ "com.google.android.apps.chrome.extra.extraFiles";

// Used to pass the CPU core count to child processes.

public static final String EXTRA_CPU_COUNT =