content/app/content_main_runner.cc - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/app/content_main_runner.cc

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: Pass FDs & Regions through to child process (Still has formatting errors) Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/app/content_main_runner.cc

diff --git a/content/app/content_main_runner.cc b/content/app/content_main_runner.cc

index 279536b09b983deec9ae5f22856e5c0bbb72f83a..692fae75e6ff4e64e425cad3e73e5ded84293fef 100644

--- a/content/app/content_main_runner.cc

+++ b/content/app/content_main_runner.cc

@@ -728,6 +728,7 @@ class ContentMainRunnerImpl : public ContentMainRunner {

#endif // !OS_ANDROID

int v8_natives_fd = g_fds->MaybeGet(kV8NativesDataDescriptor);

int v8_snapshot_fd = g_fds->MaybeGet(kV8SnapshotDataDescriptor);

+ LOG(WARNING) << "start-up f*" << v8_natives_fd;

if (v8_natives_fd != -1 && v8_snapshot_fd != -1) {

auto v8_natives_region = g_fds->GetRegion(kV8NativesDataDescriptor);

auto v8_snapshot_region = g_fds->GetRegion(kV8SnapshotDataDescriptor);

« no previous file with comments | « content/app/android/child_process_service.cc ('k') | content/browser/android/child_process_launcher_android.h » ('j') | gin/v8_initializer.cc » ('J')