chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: Pass FDs & Regions through to child process (Still has formatting errors) Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

index 44733b9627cd5e3a287ac3de1988b92720c1c636..b4ba4f0ef48c9a9aa945b8519347ce8299ebf529 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

@@ -27,8 +27,6 @@ public class CastApplication extends ContentApplication {

private static final String[] MANDATORY_PAK_FILES = new String[] {

"cast_shell.pak",

"icudtl.dat",

- "natives_blob.bin",

- "snapshot_blob.bin"

};

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "cast_shell";

private static final String COMMAND_LINE_FILE = "/data/local/tmp/castshell-command-line";

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chromecast/browser/cast_content_browser_client.h » ('j') | gin/v8_initializer.cc » ('J')