chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: Pass FDs & Regions through to child process (Still has formatting errors) Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | gin/v8_initializer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

index 1dca3dd6895d9db89c5993f67fcda57988a572aa..b27336270d97a1f7b3521c545841bddf352aca32 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

@@ -33,18 +33,12 @@ public class ChromeShellApplication extends ChromiumApplication {

* for its operation. We used to link the data statically to our binary,

* but don't do that any more and need to install along with pak files.

* See src/third_party/icu/README.chromium.

- *

- * V8's initial snapshot used to be statically linked to the binary, but

- * now it's loaded from external files. Therefore we need to install such

- * snapshots (natives_blob.bin and snapshot.bin) along with pak files.

private static final String[] CHROME_MANDATORY_PAKS = {

"en-US.pak",

"resources.pak",

"chrome_100_percent.pak",

"icudtl.dat",

- "natives_blob.bin",

- "snapshot_blob.bin"

};

private static final String COMMAND_LINE_FILE = "/data/local/tmp/chrome-shell-command-line";