content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

diff --git a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

index c34c6a587bddb71a864400fb9b62714d5538f379..d675a0b67187edf6339959c8c72905d3d95e860a 100644

--- a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

+++ b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

@@ -16,15 +16,8 @@ import org.chromium.content.app.ContentApplication;

public class ContentShellApplication extends ContentApplication {

public static final String COMMAND_LINE_FILE = "/data/local/tmp/content-shell-command-line";

- /**

- * V8's initial snapshot used to be statically linked to the binary, but

- * now it's loaded from external files. Therefore we need to install such

- * snapshots (natives_blob.bin and snapshot.bin) along with pak files.

- */

private static final String[] MANDATORY_PAK_FILES = new String[] {

"content_shell.pak",

- "natives_blob.bin",

- "snapshot_blob.bin"

};

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "content_shell";