Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java
diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java
index 587d3be32bb4fdd4fab43f83ebb62d3198f40495..042e2c774bf69793614bb7ba78954a9a0eaa26b0 100644
--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java
+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java
@@ -28,22 +28,10 @@ import java.util.ArrayList;
public class ChromeShellApplication extends ChromiumApplication {
private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "chromeshell";
- /**
- * icudtl.dat provides ICU (i18n library) with all the necessary data
- * for its operation. We used to link the data statically to our binary,
- * but don't do that any more and need to install along with pak files.
- * See src/third_party/icu/README.chromium.
- *
- * V8's initial snapshot used to be statically linked to the binary, but
- * now it's loaded from external files. Therefore we need to install such
- * snapshots (natives_blob.bin and snapshot.bin) along with pak files.
- */
private static final String[] CHROME_MANDATORY_PAKS = {
"en-US.pak",
"resources.pak",
"chrome_100_percent.pak",
- "natives_blob.bin",
- "snapshot_blob.bin"
};
private static final String COMMAND_LINE_FILE = "/data/local/tmp/chrome-shell-command-line";

Powered by Google App Engine
This is Rietveld 408576698