base/android/java/src/org/chromium/base/ResourceExtractor.java - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/java/src/org/chromium/base/ResourceExtractor.java

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/java/src/org/chromium/base/ResourceExtractor.java

diff --git a/base/android/java/src/org/chromium/base/ResourceExtractor.java b/base/android/java/src/org/chromium/base/ResourceExtractor.java

index d44f2fc7c22bdc1697571606c3465a0bc902f3f4..dd654ff6efb67fe4b05333701e21f418fcc9f6c7 100644

--- a/base/android/java/src/org/chromium/base/ResourceExtractor.java

+++ b/base/android/java/src/org/chromium/base/ResourceExtractor.java

@@ -309,6 +309,7 @@ public class ResourceExtractor {

* required, pass a single empty string.

public static void setMandatoryPaksToExtract(String... mandatoryPaks) {

+ // TODO(agrieve): Remove the need to call this once all files are loaded from the apk.

assert (sInstance == null || sInstance.mExtractTask == null)

: "Must be called before startExtractingResources is called";

sMandatoryPaks = mandatoryPaks;

@@ -346,8 +347,6 @@ public class ResourceExtractor {

} catch (IOException e) {

Log.w(LOGTAG, "Exception while accessing assets: " + e.getMessage(), e);

}

- pakAndSnapshotFileAssets.add("natives_blob.bin");

- pakAndSnapshotFileAssets.add("snapshot_blob.bin");

setMandatoryPaksToExtract(pakAndSnapshotFileAssets.toArray(

new String[pakAndSnapshotFileAssets.size()]));

}