Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2824)

Unified Diff: android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer
Patch Set: rebase for review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
diff --git a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
index 070b1a67b3631c47882ed9f7de32f48a6b7f29b5..986785ea4ad76dd3ee9947ef650b21b426f163d3 100644
--- a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
+++ b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java
@@ -21,7 +21,6 @@ public class AwShellApplication extends ContentApplication {
private static final String TAG = "AwShellApplication";
/** The minimum set of .pak files the test runner needs. */
- private static final String[] MANDATORY_PAKS = {"natives_blob.bin", "snapshot_blob.bin"};
@Override
public void onCreate() {
@@ -47,7 +46,7 @@ public class AwShellApplication extends ContentApplication {
@Override
protected void initializeLibraryDependencies() {
- ResourceExtractor.setMandatoryPaksToExtract(MANDATORY_PAKS);
+ ResourceExtractor.setMandatoryPaksToExtract("");
rmcilroy 2015/06/15 10:21:02 Same question as before - can we just remove this
agrieve 2015/06/15 14:22:04 We can't. ResourceExtractor asserts that setMandat
rmcilroy 2015/06/15 17:39:42 Ok makes sense. Could you add a TODO to tidy this
ResourceExtractor.setExtractImplicitLocaleForTesting(false);
}
« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/ResourceExtractor.java » ('j') | gin/v8_initializer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698