chromecast/browser/cast_content_browser_client.h - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/cast_content_browser_client.h

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: Keep extracting for components/ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java ('K') | « chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java ('k') | chromecast/browser/cast_content_browser_client.cc » ('j') | content/shell/browser/shell_content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/cast_content_browser_client.h

diff --git a/chromecast/browser/cast_content_browser_client.h b/chromecast/browser/cast_content_browser_client.h

index 703af237f44a0b4f30d3fd0ee88aad4cb7b2316f..e1f542e3ab51484238f87f60be90983de3d7c7af 100644

--- a/chromecast/browser/cast_content_browser_client.h

+++ b/chromecast/browser/cast_content_browser_client.h

@@ -12,6 +12,7 @@

#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

#include "content/public/browser/content_browser_client.h"

+#include "gin/v8_initializer.h"

namespace breakpad {

class CrashHandlerHostLinux;

@@ -153,10 +154,7 @@ class CastContentBrowserClient: public content::ContentBrowserClient {

std::map<std::string, breakpad::CrashHandlerHostLinux*> crash_handlers_;

#endif

- base::ScopedFD v8_natives_fd_;

- base::ScopedFD v8_snapshot_fd_;

- bool natives_fd_exists() { return v8_natives_fd_ != -1; }

- bool snapshot_fd_exists() { return v8_snapshot_fd_ != -1; }

+ gin::V8Initializer::V8Files v8_files_;

scoped_ptr<URLRequestContextFactory> url_request_context_factory_;