chrome/browser/chrome_content_browser_client.h - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: Keep extracting for components/ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java ('K') | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | content/shell/browser/shell_content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.h

diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h

index 9eb05907f9953b2d35d168a542425d44c08c6226..6b4c3b0c6977ba012f6116ffb32f48e9cd78867c 100644

--- a/chrome/browser/chrome_content_browser_client.h

+++ b/chrome/browser/chrome_content_browser_client.h

@@ -16,6 +16,7 @@

#include "base/memory/weak_ptr.h"

#include "chrome/common/chrome_version_info.h"

#include "content/public/browser/content_browser_client.h"

+#include "gin/v8_initializer.h"

class ChromeContentBrowserClientParts;

@@ -310,10 +311,7 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {

#endif

#if defined(OS_POSIX) && !defined(OS_MACOSX)

- base::ScopedFD v8_natives_fd_;

- base::ScopedFD v8_snapshot_fd_;

- bool natives_fd_exists() { return v8_natives_fd_ != -1; }

- bool snapshot_fd_exists() { return v8_snapshot_fd_ != -1; }

+ gin::V8Initializer::V8Files v8_files_;

#endif // OS_POSIX && !OS_MACOSX

#if defined(OS_ANDROID)

base::ScopedFD icudtl_fd_;