ash/shell/content_client/shell_content_browser_client.h - Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/content_client/shell_content_browser_client.h

Issue 1156873002: Load v8 snapshots directly from APK (and store them uncompressed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8initializer

Patch Set: Keep extracting for components/ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java ('K') | « android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java ('k') | ash/shell/content_client/shell_content_browser_client.cc » ('j') | content/shell/browser/shell_content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/shell/content_client/shell_content_browser_client.h

diff --git a/ash/shell/content_client/shell_content_browser_client.h b/ash/shell/content_client/shell_content_browser_client.h

index 13a594e40f8e0fdcd49cfa81e31e0d7ec629375b..513da81d38f8f8afcc9781ea05824f003912be71 100644

--- a/ash/shell/content_client/shell_content_browser_client.h

+++ b/ash/shell/content_client/shell_content_browser_client.h

@@ -9,6 +9,7 @@

#include "base/compiler_specific.h"

#include "content/public/browser/content_browser_client.h"

+#include "gin/v8_initializer.h"

namespace content {

class ShellBrowserContext;

@@ -50,11 +51,7 @@ class ShellContentBrowserClient : public content::ContentBrowserClient {

private:

#if defined(OS_POSIX) && !defined(OS_MACOSX)

- bool natives_fd_exists() { return v8_natives_fd_.is_valid(); }

- bool snapshot_fd_exists() { return v8_snapshot_fd_.is_valid(); }

- base::ScopedFD v8_natives_fd_;

- base::ScopedFD v8_snapshot_fd_;

+ gin::V8Initializer::V8Files v8_files_;

#endif

ShellBrowserMainParts* shell_browser_main_parts_;