Load v8 snapshots directly from APK (and store them uncompressed)

content/shell/browser/shell_content_browser_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_SHELL_BROWSER_SHELL_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_SHELL_BROWSER_SHELL_CONTENT_BROWSER_CLIENT_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/shell/browser/shell_speech_recognition_manager_delegate.h"
+#include "gin/v8_initializer.h"
 
 namespace content {
 
 class ShellBrowserContext;
 class ShellBrowserMainParts;
 class ShellResourceDispatcherHostDelegate;
 
 class ShellContentBrowserClient : public ContentBrowserClient {
  public:
   // Gets the current instance.
@@ skipping 78 matching lines @@
   }
 
  private:
   ShellBrowserContext* ShellBrowserContextForBrowserContext(
       BrowserContext* content_browser_context);
 
   scoped_ptr<ShellResourceDispatcherHostDelegate>
       resource_dispatcher_host_delegate_;
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
-  base::ScopedFD v8_natives_fd_;
-  base::ScopedFD v8_snapshot_fd_;
-  bool natives_fd_exists() { return v8_natives_fd_ != -1; }
-  bool snapshot_fd_exists() { return v8_snapshot_fd_ != -1; }
+  gin::V8Initializer::V8Files v8_files_;

[rmcilroy, 2015/06/09 11:52:54]

Previously the fds were being stored as ScopedFD which meant they would be
closed when this object was destructed - this is no longer the case (they are
stored as raw PlatformFiles).  I think it should be OK to just make the fields
in V8Files base::ScopedFDs then the FDs will be closed automatically when the
V8Files object is destructed.

 #endif
 
   base::Closure select_client_certificate_callback_;
 
   ShellBrowserMainParts* shell_browser_main_parts_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_SHELL_BROWSER_SHELL_CONTENT_BROWSER_CLIENT_H_