Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 115683005: Pass correct --parent-window value to native messaging hosts (Closed)

Created:
6 years, 12 months ago by Sergey Ulanov
Modified:
6 years, 11 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Pass correct --parent-window value to native messaging hosts --parent-window is used to pass HWND of the chrome window when launching native messaging hosts. It was brokend with Aura because BUG=330777 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244445

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 1 2 8 chunks +19 lines, -12 lines 0 comments Download
M chrome/test/data/native_messaging/native_hosts/echo.py View 1 2 3 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
6 years, 11 months ago (2013-12-30 20:07:21 UTC) #1
miket_OOO
lgtm https://codereview.chromium.org/115683005/diff/570001/chrome/test/data/native_messaging/native_hosts/echo.py File chrome/test/data/native_messaging/native_hosts/echo.py (right): https://codereview.chromium.org/115683005/diff/570001/chrome/test/data/native_messaging/native_hosts/echo.py#newcode26 chrome/test/data/native_messaging/native_hosts/echo.py:26: caller_url = None; Begone, semicolon! https://codereview.chromium.org/115683005/diff/570001/chrome/test/data/native_messaging/native_hosts/echo.py#newcode34 chrome/test/data/native_messaging/native_hosts/echo.py:34: if ...
6 years, 11 months ago (2014-01-07 17:15:11 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/115683005/diff/570001/chrome/test/data/native_messaging/native_hosts/echo.py File chrome/test/data/native_messaging/native_hosts/echo.py (right): https://codereview.chromium.org/115683005/diff/570001/chrome/test/data/native_messaging/native_hosts/echo.py#newcode26 chrome/test/data/native_messaging/native_hosts/echo.py:26: caller_url = None; On 2014/01/07 17:15:11, miket wrote: > ...
6 years, 11 months ago (2014-01-07 20:56:10 UTC) #3
miket_OOO
> Added TODO. FWIW argparse is available only starting Python 2.7 and we are still ...
6 years, 11 months ago (2014-01-07 20:58:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/115683005/990001
6 years, 11 months ago (2014-01-12 08:46:07 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 18:21:07 UTC) #6
Message was sent while issue was closed.
Change committed as 244445

Powered by Google App Engine
This is Rietveld 408576698