Add Galaxy S4 into GPU blacklist

Add Galaxy S4 into GPU blacklist

BUG=329072
R=kbr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242581

[Ken Russell (switch to Gerrit), 2013-12-27 00:06:09]

Generally looks OK, but:

https://codereview.chromium.org/115683004/diff/1/gpu/config/software_renderin...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/115683004/diff/1/gpu/config/software_renderin...
gpu/config/software_rendering_list_json.cc:21: "version": "6.19",
Please update this version number to 6.20.

[wjia(left Chromium), 2013-12-27 00:07:41]

Thanks! PTAL.

https://codereview.chromium.org/115683004/diff/1/gpu/config/software_renderin...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/115683004/diff/1/gpu/config/software_renderin...
gpu/config/software_rendering_list_json.cc:21: "version": "6.19",
On 2013/12/27 00:06:09, Ken Russell wrote:
> Please update this version number to 6.20.

Done.

[Ken Russell (switch to Gerrit), 2013-12-27 00:11:25]

Sorry, I should have made this comment in the first iteration.

https://codereview.chromium.org/115683004/diff/50001/gpu/config/software_rend...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/115683004/diff/50001/gpu/config/software_rend...
gpu/config/software_rendering_list_json.cc:1015: "value": "4.2.2"
Do you really want this restriction in the blacklist? What happens if Android
4.2.3 comes out and the bug still isn't fixed?

If the bug is still in top-of-tree Android on this device then I think you
should remove the version restriction. The blacklist can then be updated if it's
ever fixed.

[wjia(left Chromium), 2013-12-27 00:29:56]

https://codereview.chromium.org/115683004/diff/50001/gpu/config/software_rend...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/115683004/diff/50001/gpu/config/software_rend...
gpu/config/software_rendering_list_json.cc:1015: "value": "4.2.2"
On 2013/12/27 00:11:26, Ken Russell wrote:
> Do you really want this restriction in the blacklist? What happens if Android
> 4.2.3 comes out and the bug still isn't fixed?
> 
> If the bug is still in top-of-tree Android on this device then I think you
> should remove the version restriction. The blacklist can then be updated if
it's
> ever fixed.

Done.

[Ken Russell (switch to Gerrit), 2013-12-27 00:33:26]

LGTM assuming this has been tested.

[wjia(left Chromium), 2013-12-27 01:03:06]

Committed patchset #3 manually as r242581 (presubmit successful).

[Ami GONE FROM CHROMIUM, 2014-01-07 00:50:01]

post-commit drive-by

https://codereview.chromium.org/115683004/diff/100001/gpu/config/software_ren...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/115683004/diff/100001/gpu/config/software_ren...
gpu/config/software_rendering_list_json.cc:1009: "description": "Samsung Gaxlaxy
S4 is too buggy to use for video decoding",
typo: s/Gaxlaxy/Galaxy/

https://codereview.chromium.org/115683004/diff/100001/gpu/config/software_ren...
gpu/config/software_rendering_list_json.cc:1010: "cr_bugs": [329072],
I looked for evidence of VDA crash in the logs attached to that bug but failed
to find it (instead, all the logcat outputs I see have the main buffer _already_
spewing logs implying a failed decoder, but the actual failure is already gone).
 Would you mind updating the bug to highlight the crash that this blacklist is
working around?