Issue 115683003: Do not compile OpaqueBrowserFrameView and co on CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115683003: Do not compile OpaqueBrowserFrameView and co on CrOS (Closed)

Created:
7 years ago by pkotwicz

Modified:
7 years ago

Reviewers:
oshima

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not compile OpaqueBrowserFrameView and co on CrOS BUG=None TEST=None R=oshima TBR=jamescook Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242033

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -3 lines)			Patch
M	chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/115683003/1

7 years ago (2013-12-19 18:58:39 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=42301

7 years ago (2013-12-19 19:20:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/115683003/1

7 years ago (2013-12-19 21:46:18 UTC) #5

Message was sent while issue was closed.

Change committed as 242033

Expand Messages | Collapse Messages