Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(95)

Issue 1156823005: DevTools: delete JavaScriptCallFrame.idl (Closed)

Created:
4 years, 11 months ago by yurys
Modified:
4 years, 11 months ago
Reviewers:
alph, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, pfeldman+blink_chromium.org, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vivekg, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: delete JavaScriptCallFrame.idl It is used just for type checking of InjectedScriptSource.js. This is now solved with injected_script_externs.js file. BUG=466631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196492

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -56 lines) Patch
D Source/core/inspector/JavaScriptCallFrame.idl View 1 1 chunk +0 lines, -50 lines 0 comments Download
A Source/core/inspector/injected_script_externs.js View 1 chunk +59 lines, -0 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
yurys
4 years, 11 months ago (2015-06-03 17:52:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156823005/1
4 years, 11 months ago (2015-06-03 19:58:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-06-03 21:06:52 UTC) #6
yurys
4 years, 11 months ago (2015-06-04 09:30:10 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156823005/20001
4 years, 11 months ago (2015-06-04 09:30:31 UTC) #10
sergeyv
lgtm
4 years, 11 months ago (2015-06-04 09:40:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156823005/20001
4 years, 11 months ago (2015-06-04 09:59:31 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 11:36:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196492

Powered by Google App Engine
This is Rietveld 408576698