Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1156823004: Add a cli for a running mojo:debugger. (Closed)

Created:
5 years, 6 months ago by ppi
Modified:
5 years, 6 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a cli for a running mojo:debugger. This currently allows to stop and start tracing. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/70ae7c0040a0733511f2ca674b91b39026f1f8c7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Patch Set 3 : Add a blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A mojo/devtools/common/debugger View 1 2 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ppi
Hi Ben, ptal.
5 years, 6 months ago (2015-06-03 14:11:26 UTC) #1
qsr
lgtm https://codereview.chromium.org/1156823004/diff/1/mojo/devtools/common/debugger File mojo/devtools/common/debugger (right): https://codereview.chromium.org/1156823004/diff/1/mojo/devtools/common/debugger#newcode19 mojo/devtools/common/debugger:19: return response You probably should remove payload as ...
5 years, 6 months ago (2015-06-03 15:20:40 UTC) #2
ppi
https://codereview.chromium.org/1156823004/diff/1/mojo/devtools/common/debugger File mojo/devtools/common/debugger (right): https://codereview.chromium.org/1156823004/diff/1/mojo/devtools/common/debugger#newcode19 mojo/devtools/common/debugger:19: return response On 2015/06/03 15:20:40, qsr wrote: > You ...
5 years, 6 months ago (2015-06-03 15:24:04 UTC) #3
ppi
5 years, 6 months ago (2015-06-03 15:25:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
70ae7c0040a0733511f2ca674b91b39026f1f8c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698