Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1156803004: Change image processor name from /dev/gsc0 to /dev/image-proc0. (Closed)

Created:
5 years, 6 months ago by wuchengli
Modified:
5 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change image processor name from /dev/gsc0 to /dev/image-proc0. Another platform will have image processor. Change the device name of image processor to more generic. BUG=chrome-os-partner:38980 TEST=Test apprtc loopback on peach pit. Committed: https://crrev.com/163ccd4dc86b9af0dcfba83d34f90b1099f6ec72 Cr-Commit-Position: refs/heads/master@{#333674}

Patch Set 1 #

Patch Set 2 : rename image-proc to image-proc0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/common/gpu/media/generic_v4l2_device.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
wuchengli
PTAL
5 years, 6 months ago (2015-06-08 07:00:12 UTC) #2
henryhsu
LGTM. And we also need a CL on chromeos side to modify media-rules.
5 years, 6 months ago (2015-06-08 07:42:14 UTC) #3
wuchengli
PTAL
5 years, 6 months ago (2015-06-08 09:10:42 UTC) #4
wuchengli
jorgelo: OWNER review for bpf_cros_arm_gpu_policy_linux.cc. Thanks.
5 years, 6 months ago (2015-06-09 06:12:16 UTC) #6
Pawel Osciak
lgtm
5 years, 6 months ago (2015-06-09 06:54:41 UTC) #7
Jorge Lucangeli Obes
lgtm
5 years, 6 months ago (2015-06-09 14:52:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156803004/20001
5 years, 6 months ago (2015-06-10 02:53:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 03:29:31 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 03:30:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/163ccd4dc86b9af0dcfba83d34f90b1099f6ec72
Cr-Commit-Position: refs/heads/master@{#333674}

Powered by Google App Engine
This is Rietveld 408576698