Revert 172828. This broke check_deps. You identified this problem

Revert 172828. This broke check_deps. You identified this problem
in the code review comments, not sure what went wrong. Was the wrong
patch set committed?
> Make it harder to accidentally run envsetup.sh in a subshell 
> (instead of sourcing it in the current shell).
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11547023

TBR=fischman@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172836

[Isaac (away), 2012-12-13 09:11:09]

Looks like the script didn't get chmoded in the svn commit.  Maybe a bug with
dcommit?

The intention was chmod -x on this script.  can we just do that instead of
reverting?

[Isaac (away), 2012-12-13 09:11:56]

Sorry - didn't realize it was already committed.

[marja, 2012-12-13 09:17:37]

Yup, I reverted this already. The original CL went through the commit queue;
afaic the CQ should process the mod changes correctly. maruel@, any known issues
here?

[Isaac (away), 2012-12-13 09:30:38]

It is a known issue that CQ does not run check deps.  I forwarded you an email
about it from a while ago.

I suggest filing a go/chromeinfraticket bug about it and having crbug.com/108484
block on your new bug.

[Isaac (away), 2012-12-13 09:33:00]

Oops, my mistake, the crbug I referenced is a bit difference.  So maybe just
file an infra ticket and wait for it to be triaged.

[Ami GONE FROM CHROMIUM, 2012-12-13 18:10:33]

I filed http://crbug.com/165964 about CQ's failure to apply my chmod when
landing the CL.

[Ami GONE FROM CHROMIUM, 2012-12-13 19:27:25]

On 2012/12/13 18:10:33, Ami Fischman wrote:
> I filed http://crbug.com/165964 about CQ's failure to apply my chmod when
> landing the CL.

FTR bot failure was
http://build.chromium.org/p/chromium/builders/Linux/builds/34391/steps/check_...

Manually relanded original CL as r172912, now passing the bot:
http://build.chromium.org/p/chromium/builders/Linux/builds/34411/steps/check_...