Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 11568006: events: Update scroll and touch handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: self-nit Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/native_widget_aura.h ('k') | ui/views/widget/native_widget_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index 3740dae60c940167aaa2ffe06503439165c5a103..52c77483c61ba7cfbf22cf48046ea13a0ebaecea 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -794,22 +794,24 @@ ui::EventResult NativeWidgetAura::OnMouseEvent(ui::MouseEvent* event) {
return delegate_->OnMouseEvent(*event) ? ui::ER_HANDLED : ui::ER_UNHANDLED;
}
-ui::EventResult NativeWidgetAura::OnScrollEvent(ui::ScrollEvent* event) {
+void NativeWidgetAura::OnScrollEvent(ui::ScrollEvent* event) {
if (event->type() == ui::ET_SCROLL) {
- ui::EventResult status = delegate_->OnScrollEvent(event);
- if (status != ui::ER_UNHANDLED)
- return status;
+ delegate_->OnScrollEvent(event);
+ if (event->handled())
+ return;
// Convert unprocessed scroll events into wheel events.
ui::MouseWheelEvent mwe(*static_cast<ui::ScrollEvent*>(event));
- return delegate_->OnMouseEvent(mwe) ? ui::ER_HANDLED : ui::ER_UNHANDLED;
+ if (delegate_->OnMouseEvent(mwe))
+ event->SetHandled();
+ return;
}
- return delegate_->OnScrollEvent(event);
+ delegate_->OnScrollEvent(event);
}
-ui::EventResult NativeWidgetAura::OnTouchEvent(ui::TouchEvent* event) {
+void NativeWidgetAura::OnTouchEvent(ui::TouchEvent* event) {
DCHECK(window_->IsVisible());
- return delegate_->OnTouchEvent(event);
+ delegate_->OnTouchEvent(event);
}
void NativeWidgetAura::OnGestureEvent(ui::GestureEvent* event) {
« no previous file with comments | « ui/views/widget/native_widget_aura.h ('k') | ui/views/widget/native_widget_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698