Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: ui/views/corewm/compound_event_filter.cc

Issue 11568006: events: Update scroll and touch handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: self-nit Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/corewm/compound_event_filter.h ('k') | ui/views/corewm/focus_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/corewm/compound_event_filter.cc
diff --git a/ui/views/corewm/compound_event_filter.cc b/ui/views/corewm/compound_event_filter.cc
index fe83efd8f2b8697cd91e66e93c83242237482301..9e857c6117c928a2d4a2708a272efed92707a2ad 100644
--- a/ui/views/corewm/compound_event_filter.cc
+++ b/ui/views/corewm/compound_event_filter.cc
@@ -161,16 +161,13 @@ ui::EventResult CompoundEventFilter::FilterMouseEvent(ui::MouseEvent* event) {
return static_cast<ui::EventResult>(result);
}
-ui::EventResult CompoundEventFilter::FilterTouchEvent(ui::TouchEvent* event) {
- int result = ui::ER_UNHANDLED;
+void CompoundEventFilter::FilterTouchEvent(ui::TouchEvent* event) {
if (handlers_.might_have_observers()) {
ObserverListBase<ui::EventHandler>::Iterator it(handlers_);
ui::EventHandler* handler;
- while (!(result & ui::ER_CONSUMED) && (handler = it.GetNext()) != NULL) {
- result |= handler->OnTouchEvent(event);
- }
+ while (!event->stopped_propagation() && (handler = it.GetNext()) != NULL)
+ handler->OnTouchEvent(event);
}
- return static_cast<ui::EventResult>(result);
}
void CompoundEventFilter::SetCursorVisibilityOnEvent(aura::Window* target,
@@ -228,18 +225,15 @@ ui::EventResult CompoundEventFilter::OnMouseEvent(ui::MouseEvent* event) {
return FilterMouseEvent(event);
}
-ui::EventResult CompoundEventFilter::OnScrollEvent(ui::ScrollEvent* event) {
- return ui::ER_UNHANDLED;
+void CompoundEventFilter::OnScrollEvent(ui::ScrollEvent* event) {
}
-ui::EventResult CompoundEventFilter::OnTouchEvent(ui::TouchEvent* event) {
- ui::EventResult result = FilterTouchEvent(event);
- if (result == ui::ER_UNHANDLED &&
- event->type() == ui::ET_TOUCH_PRESSED) {
+void CompoundEventFilter::OnTouchEvent(ui::TouchEvent* event) {
+ FilterTouchEvent(event);
+ if (!event->handled() && event->type() == ui::ET_TOUCH_PRESSED) {
SetCursorVisibilityOnEvent(
static_cast<aura::Window*>(event->target()), event, false);
}
- return result;
}
void CompoundEventFilter::OnGestureEvent(ui::GestureEvent* event) {
« no previous file with comments | « ui/views/corewm/compound_event_filter.h ('k') | ui/views/corewm/focus_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698