Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: ui/base/events/event_dispatcher_unittest.cc

Issue 11568006: events: Update scroll and touch handlers to not return EventResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: self-nit Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/aura/window_unittest.cc ('k') | ui/base/events/event_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/events/event_dispatcher.h" 5 #include "ui/base/events/event_dispatcher.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace ui { 9 namespace ui {
10 10
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 virtual EventResult OnKeyEvent(KeyEvent* event) OVERRIDE { 83 virtual EventResult OnKeyEvent(KeyEvent* event) OVERRIDE {
84 ReceivedEvent(event); 84 ReceivedEvent(event);
85 return event_result_; 85 return event_result_;
86 } 86 }
87 87
88 virtual EventResult OnMouseEvent(MouseEvent* event) OVERRIDE { 88 virtual EventResult OnMouseEvent(MouseEvent* event) OVERRIDE {
89 ReceivedEvent(event); 89 ReceivedEvent(event);
90 return event_result_; 90 return event_result_;
91 } 91 }
92 92
93 virtual EventResult OnScrollEvent(ScrollEvent* event) OVERRIDE { 93 virtual void OnScrollEvent(ScrollEvent* event) OVERRIDE {
94 ReceivedEvent(event); 94 ReceivedEvent(event);
95 return event_result_; 95 SetStatusOnEvent(event);
96 } 96 }
97 97
98 virtual EventResult OnTouchEvent(TouchEvent* event) OVERRIDE { 98 virtual void OnTouchEvent(TouchEvent* event) OVERRIDE {
99 ReceivedEvent(event); 99 ReceivedEvent(event);
100 return event_result_; 100 SetStatusOnEvent(event);
101 } 101 }
102 102
103 virtual void OnGestureEvent(GestureEvent* event) OVERRIDE { 103 virtual void OnGestureEvent(GestureEvent* event) OVERRIDE {
104 ReceivedEvent(event); 104 ReceivedEvent(event);
105 SetStatusOnEvent(event);
106 }
107
108 void SetStatusOnEvent(Event* event) {
105 if (event_result_ & ui::ER_CONSUMED) 109 if (event_result_ & ui::ER_CONSUMED)
106 event->StopPropagation(); 110 event->StopPropagation();
107 if (event_result_ & ui::ER_HANDLED) 111 if (event_result_ & ui::ER_HANDLED)
108 event->SetHandled(); 112 event->SetHandled();
109 } 113 }
110 114
111 int id_; 115 int id_;
112 EventResult event_result_; 116 EventResult event_result_;
113 bool expect_pre_target_; 117 bool expect_pre_target_;
114 bool expect_post_target_; 118 bool expect_post_target_;
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 h3->set_expect_pre_target(false); 466 h3->set_expect_pre_target(false);
463 467
464 MouseEvent mouse(ui::ET_MOUSE_MOVED, gfx::Point(3, 4), gfx::Point(3, 4), 0); 468 MouseEvent mouse(ui::ET_MOUSE_MOVED, gfx::Point(3, 4), gfx::Point(3, 4), 0);
465 dispatcher->ProcessEvent(&target, &mouse); 469 dispatcher->ProcessEvent(&target, &mouse);
466 EXPECT_TRUE(mouse.stopped_propagation()); 470 EXPECT_TRUE(mouse.stopped_propagation());
467 EXPECT_EQ(2U, target.handler_list().size()); 471 EXPECT_EQ(2U, target.handler_list().size());
468 EXPECT_EQ(1, target.handler_list()[0]); 472 EXPECT_EQ(1, target.handler_list()[0]);
469 EXPECT_EQ(2, target.handler_list()[1]); 473 EXPECT_EQ(2, target.handler_list()[1]);
470 } 474 }
471 } // namespace ui 475 } // namespace ui
OLDNEW
« no previous file with comments | « ui/aura/window_unittest.cc ('k') | ui/base/events/event_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698