Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1156783004: cr-settings-checkbox: Add 'inverted' property. (Closed)

Created:
5 years, 6 months ago by Oren Blasberg
Modified:
5 years, 6 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cr-settings-checkbox: Add 'inverted' property. This will allow us to use it in the Users page (and potentially others) for the prefs where the checkbox being checked means the boolean pref is disabled, and unchecked means enabled. Example usage: <cr-settings-checkbox pref="{{prefs.cros.accounts.allowGuest}}" inverted> </cr-settings-checkbox> BUG=495858 Committed: https://crrev.com/d9f0ed3087ef9d25bcaed6ed749979fdec9fdf20 Cr-Commit-Position: refs/heads/master@{#333110}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address Jeremy's comments #

Patch Set 3 : Keep pref's default unset, but fix the error. #

Patch Set 4 : Rename that method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M chrome/browser/resources/settings/checkbox/checkbox.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/checkbox/checkbox.js View 1 2 3 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 20 (5 generated)
Oren Blasberg
5 years, 6 months ago (2015-06-03 22:12:06 UTC) #2
Jeremy Klein
Make sure you test this out in your other CL. https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js File chrome/browser/resources/settings/checkbox/checkbox.js (right): https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js#newcode27 ...
5 years, 6 months ago (2015-06-04 00:49:54 UTC) #3
James Hawkins
Can you add a usage in this CL? It would be good to see how ...
5 years, 6 months ago (2015-06-04 01:14:41 UTC) #5
James Hawkins
On 2015/06/04 01:14:41, James Hawkins wrote: > Can you add a usage in this CL? ...
5 years, 6 months ago (2015-06-04 01:15:05 UTC) #6
Oren Blasberg
On 2015/06/04 00:49:54, Jeremy Klein wrote: > Make sure you test this out in your ...
5 years, 6 months ago (2015-06-04 01:38:54 UTC) #7
Oren Blasberg
https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js File chrome/browser/resources/settings/checkbox/checkbox.js (right): https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js#newcode27 chrome/browser/resources/settings/checkbox/checkbox.js:27: value: function() { return {}; } On 2015/06/04 00:49:54, ...
5 years, 6 months ago (2015-06-04 16:10:04 UTC) #8
Jeremy Klein
https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js File chrome/browser/resources/settings/checkbox/checkbox.js (right): https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js#newcode27 chrome/browser/resources/settings/checkbox/checkbox.js:27: value: function() { return {}; } On 2015/06/04 16:10:04, ...
5 years, 6 months ago (2015-06-04 17:20:16 UTC) #9
Oren Blasberg
https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js File chrome/browser/resources/settings/checkbox/checkbox.js (right): https://codereview.chromium.org/1156783004/diff/1/chrome/browser/resources/settings/checkbox/checkbox.js#newcode27 chrome/browser/resources/settings/checkbox/checkbox.js:27: value: function() { return {}; } On 2015/06/04 17:20:16, ...
5 years, 6 months ago (2015-06-04 18:26:11 UTC) #10
Oren Blasberg
Ok, resolved the checkboxChanged_ stuff offline and renamed the method.
5 years, 6 months ago (2015-06-05 01:02:49 UTC) #11
Jeremy Klein
lgtm
5 years, 6 months ago (2015-06-05 01:03:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156783004/60001
5 years, 6 months ago (2015-06-05 01:06:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/30310)
5 years, 6 months ago (2015-06-05 02:30:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156783004/60001
5 years, 6 months ago (2015-06-05 19:06:28 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-05 19:45:32 UTC) #19
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:00:20 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d9f0ed3087ef9d25bcaed6ed749979fdec9fdf20
Cr-Commit-Position: refs/heads/master@{#333110}

Powered by Google App Engine
This is Rietveld 408576698