Honor 'sysroot' setting when running cups-config

Honor 'sysroot' setting when running cups-config

This mimic the existing behavior of build/linux/pkg-config-wrapper.

Committed: https://crrev.com/05ac52d4344270b0253d0b789e8621966d3af130
Cr-Commit-Position: refs/heads/master@{#331207}

[Sam Clegg, 2015-05-22 20:17:50]

sbc@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2015-05-22 22:12:14]

vitalybuka@chromium.org changed reviewers:
+ thestig@chromium.org

[Vitaly Buka (NO REVIEWS), 2015-05-22 22:12:30]

lgtm

[Sam Clegg, 2015-05-22 22:13:26]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-05-22 22:13:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1156773004/1

[commit-bot: I haz the power, 2015-05-22 23:51:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-22 23:52:29]

Patchset 1 (id:??) landed as
https://crrev.com/05ac52d4344270b0253d0b789e8621966d3af130
Cr-Commit-Position: refs/heads/master@{#331207}

[Evan Stade, 2015-08-06 17:55:28]

On 2015/05/22 23:52:29, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/05ac52d4344270b0253d0b789e8621966d3af130
> Cr-Commit-Position: refs/heads/master@{#331207}

this seems to have broken local branded builds for me on my linux workstation.
When running gclient runhooks I get 

python printing/cups_config_helper.py --libs
/usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot
cups-config not found:
/usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot/usr/bin/cups-config

and it resolves when I revert this patch.

[Sam Clegg, 2015-08-06 18:00:51]

On 2015/08/06 17:55:28, Evan Stade wrote:
> On 2015/05/22 23:52:29, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/05ac52d4344270b0253d0b789e8621966d3af130
> > Cr-Commit-Position: refs/heads/master@{#331207}
> 
> this seems to have broken local branded builds for me on my linux workstation.
> When running gclient runhooks I get 
> 
> python printing/cups_config_helper.py --libs
> /usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot
> cups-config not found:
>
/usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot/usr/bin/cups-config
> 
> and it resolves when I revert this patch.

What GYP_DEFINES are you using?  Does the sysroot exist?  It should be installed
automatically by gclient runhooks if you are building with sysroot=1 or doing an
official chrome build.

[Evan Stade, 2015-08-06 18:03:41]

On 2015/08/06 17:55:28, Evan Stade wrote:
> On 2015/05/22 23:52:29, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/05ac52d4344270b0253d0b789e8621966d3af130
> > Cr-Commit-Position: refs/heads/master@{#331207}
> 
> this seems to have broken local branded builds for me on my linux workstation.
> When running gclient runhooks I get 
> 
> python printing/cups_config_helper.py --libs
> /usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot
> cups-config not found:
>
/usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot/usr/bin/cups-config
> 
> and it resolves when I revert this patch.

false alarm --- oddly this happens only when I add branding=Chrome
buildtype=Official to chromium.gyp_env but if I use GYP_DEFINES="..." it works
fine.

[Sam Clegg, 2015-08-06 18:06:26]

On 2015/08/06 18:03:41, Evan Stade wrote:
> On 2015/08/06 17:55:28, Evan Stade wrote:
> > On 2015/05/22 23:52:29, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/05ac52d4344270b0253d0b789e8621966d3af130
> > > Cr-Commit-Position: refs/heads/master@{#331207}
> > 
> > this seems to have broken local branded builds for me on my linux
workstation.
> > When running gclient runhooks I get 
> > 
> > python printing/cups_config_helper.py --libs
> > /usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot
> > cups-config not found:
> >
>
/usr/local/google/chrome/src/build/linux/debian_wheezy_amd64-sysroot/usr/bin/cups-config
> > 
> > and it resolves when I revert this patch.
> 
> false alarm --- oddly this happens only when I add branding=Chrome
> buildtype=Official to chromium.gyp_env but if I use GYP_DEFINES="..." it works
> fine.

Yes, sadly the runhooks which installs the system, peeks into GYP_DEFINES to
figure out for example which target_arch you are building for.  Its a bit of a
hack.. but we've yet to come up with a better way to do conditional stuff in the
hooks.