Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1156763002: Add "realpath" to CrOS build deps. (Closed)

Created:
5 years, 7 months ago by dnj
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "realpath" to CrOS build deps. "realpath" is used by several CrOS tools. It is needed on builders that build Chromium through the CrOS toolchain. BUG=chromium:491287 TEST=None Committed: https://crrev.com/6a8491d157d1613c41426e91a3ac479766dd7a31 Cr-Commit-Position: refs/heads/master@{#331434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
dnj
PTAL!
5 years, 7 months ago (2015-05-22 19:19:14 UTC) #2
hinoka
lgtm
5 years, 7 months ago (2015-05-22 19:21:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156763002/1
5 years, 7 months ago (2015-05-22 20:14:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/65589)
5 years, 7 months ago (2015-05-22 20:23:39 UTC) #7
dnj
ping!
5 years, 7 months ago (2015-05-26 17:38:47 UTC) #8
Sam Clegg
On 2015/05/26 17:38:47, dnj wrote: > ping! You need to find someone from build/OWNERS I ...
5 years, 7 months ago (2015-05-26 17:43:57 UTC) #9
dnj
Oh I'm sorry, I assumed from your presence on previous reviews that you were, but ...
5 years, 7 months ago (2015-05-26 17:53:32 UTC) #11
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-26 20:52:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156763002/1
5 years, 7 months ago (2015-05-26 20:56:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 21:08:24 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 21:09:14 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a8491d157d1613c41426e91a3ac479766dd7a31
Cr-Commit-Position: refs/heads/master@{#331434}

Powered by Google App Engine
This is Rietveld 408576698