Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 1156743008: Add experimental support for python in 'git cl format' (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, eliben_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add experimental support for python in 'git cl format' Based on yapf (https://github.com/google/yapf) this formatter currently only works with --full. It defaults to pep8 style and projects that use a different style can add .style.yapf to the top level. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295547

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -24 lines) Patch
A .style.yapf View 1 chunk +2 lines, -0 lines 0 comments Download
M gclient_utils.py View 4 chunks +22 lines, -0 lines 0 comments Download
M git_cache.py View 2 chunks +3 lines, -20 lines 0 comments Download
M git_cl.py View 1 3 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam Clegg
5 years, 6 months ago (2015-06-05 23:00:37 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/1156743008/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1156743008/diff/1/git_cl.py#newcode3288 git_cl.py:3288: stdout = RunCommand(cmd + files, cwd=top_dir) bYou are ...
5 years, 6 months ago (2015-06-05 23:09:53 UTC) #3
Sam Clegg
https://codereview.chromium.org/1156743008/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1156743008/diff/1/git_cl.py#newcode3288 git_cl.py:3288: stdout = RunCommand(cmd + files, cwd=top_dir) On 2015/06/05 23:09:53, ...
5 years, 6 months ago (2015-06-05 23:13:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156743008/20001
5 years, 6 months ago (2015-06-05 23:14:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295547
5 years, 6 months ago (2015-06-05 23:16:56 UTC) #8
Dirk Pranke
5 years, 6 months ago (2015-06-05 23:17:53 UTC) #9
Message was sent while issue was closed.
+joelo, fyi, since we were talking about this possibly replacing
format-webkitpy

On Fri, Jun 5, 2015 at 4:16 PM, 'commit-bot: I haz the power' via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Committed patchset #2 (id:20001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=295547
>
> https://codereview.chromium.org/1156743008/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698