Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1156733003: Move PageState to FrameNavigationEntry. (Closed)

Created:
5 years, 6 months ago by Charlie Reis
Modified:
5 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PageState to FrameNavigationEntry. This will allow us to store frame-specific states in --site-per-process, which is necessary to support back/forward in out-of-process iframes. BUG=236848 TEST=No behavior change. Committed: https://crrev.com/44a0941b338626983b5215cfce34ce64eac84a85 Cr-Commit-Position: refs/heads/master@{#333224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M content/browser/frame_host/frame_navigation_entry.h View 4 chunks +8 lines, -1 line 0 comments Download
M content/browser/frame_host/frame_navigation_entry.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
This is just some prep work for subframe back/forward. It's mostly a no-op for now, ...
5 years, 6 months ago (2015-06-05 23:37:09 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 6 months ago (2015-06-06 02:48:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156733003/1
5 years, 6 months ago (2015-06-07 02:44:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-07 03:37:12 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-07 03:38:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44a0941b338626983b5215cfce34ce64eac84a85
Cr-Commit-Position: refs/heads/master@{#333224}

Powered by Google App Engine
This is Rietveld 408576698