src/api.cc - Issue 1156733002: Implement bookmarks for ExternalStreamingStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1156733002: Implement bookmarks for ExternalStreamingStream. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 125a31be06f94b802e9f61a465335ee641b8c189..2e8c9589e9e670bc0a425297dbdede36413b261a 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -1525,6 +1525,12 @@ ScriptCompiler::CachedData::~CachedData() {

}

+bool ScriptCompiler::ExternalSourceStream::SetBookmark() { return false; }

+void ScriptCompiler::ExternalSourceStream::ResetToBookmark() { UNREACHABLE(); }

ScriptCompiler::StreamedSource::StreamedSource(ExternalSourceStream* stream,

Encoding encoding)

: impl_(new i::StreamedSource(stream, encoding)) {}