Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/api.cc

Issue 1156733002: Implement bookmarks for ExternalStreamingStream. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comments to interface methods. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/v8.h ('k') | src/scanner-character-streams.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/api.h" 5 #include "src/api.h"
6 6
7 #include <string.h> // For memcpy, strlen. 7 #include <string.h> // For memcpy, strlen.
8 #ifdef V8_USE_ADDRESS_SANITIZER 8 #ifdef V8_USE_ADDRESS_SANITIZER
9 #include <sanitizer/asan_interface.h> 9 #include <sanitizer/asan_interface.h>
10 #endif // V8_USE_ADDRESS_SANITIZER 10 #endif // V8_USE_ADDRESS_SANITIZER
(...skipping 1507 matching lines...) Expand 10 before | Expand all | Expand 10 after
1518 buffer_policy(buffer_policy_) {} 1518 buffer_policy(buffer_policy_) {}
1519 1519
1520 1520
1521 ScriptCompiler::CachedData::~CachedData() { 1521 ScriptCompiler::CachedData::~CachedData() {
1522 if (buffer_policy == BufferOwned) { 1522 if (buffer_policy == BufferOwned) {
1523 delete[] data; 1523 delete[] data;
1524 } 1524 }
1525 } 1525 }
1526 1526
1527 1527
1528 bool ScriptCompiler::ExternalSourceStream::SetBookmark() { return false; }
1529
1530
1531 void ScriptCompiler::ExternalSourceStream::ResetToBookmark() { UNREACHABLE(); }
1532
1533
1528 ScriptCompiler::StreamedSource::StreamedSource(ExternalSourceStream* stream, 1534 ScriptCompiler::StreamedSource::StreamedSource(ExternalSourceStream* stream,
1529 Encoding encoding) 1535 Encoding encoding)
1530 : impl_(new i::StreamedSource(stream, encoding)) {} 1536 : impl_(new i::StreamedSource(stream, encoding)) {}
1531 1537
1532 1538
1533 ScriptCompiler::StreamedSource::~StreamedSource() { delete impl_; } 1539 ScriptCompiler::StreamedSource::~StreamedSource() { delete impl_; }
1534 1540
1535 1541
1536 const ScriptCompiler::CachedData* 1542 const ScriptCompiler::CachedData*
1537 ScriptCompiler::StreamedSource::GetCachedData() const { 1543 ScriptCompiler::StreamedSource::GetCachedData() const {
(...skipping 6541 matching lines...) Expand 10 before | Expand all | Expand 10 after
8079 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate()); 8085 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
8080 Address callback_address = 8086 Address callback_address =
8081 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 8087 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
8082 VMState<EXTERNAL> state(isolate); 8088 VMState<EXTERNAL> state(isolate);
8083 ExternalCallbackScope call_scope(isolate, callback_address); 8089 ExternalCallbackScope call_scope(isolate, callback_address);
8084 callback(info); 8090 callback(info);
8085 } 8091 }
8086 8092
8087 8093
8088 } } // namespace v8::internal 8094 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « include/v8.h ('k') | src/scanner-character-streams.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698