Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Issue 1156733002: Implement bookmarks for ExternalStreamingStream. (Closed)

Created:
5 years, 7 months ago by vogelheim
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement bookmarks for ExternalStreamingStream. (Requires the embedder's ExternalSourceStream implementation to cooperate. See crrev.com/1154883003 for Blink.) R=jochen@chromium.org BUG=chromium:470930 LOG=Y Committed: https://crrev.com/85a0542df592cc297f52f00e00d74ada1206efdf Cr-Commit-Position: refs/heads/master@{#28610}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Let's try to make the windows compiler happy. #

Patch Set 3 : Add comments to interface methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -10 lines) Patch
M include/v8.h View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/scanner-character-streams.h View 3 chunks +17 lines, -2 lines 0 comments Download
M src/scanner-character-streams.cc View 1 2 chunks +66 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vogelheim
5 years, 7 months ago (2015-05-22 15:12:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/1156733002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1156733002/diff/1/include/v8.h#newcode1226 include/v8.h:1226: virtual bool SetBookmark(); Please add a ...
5 years, 7 months ago (2015-05-22 15:54:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nit
5 years, 7 months ago (2015-05-22 15:54:30 UTC) #3
vogelheim
On 2015/05/22 15:54:30, jochen wrote: > lgtm with nit > > https://codereview.chromium.org/1156733002/diff/1/include/v8.h > File include/v8.h ...
5 years, 7 months ago (2015-05-26 06:54:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156733002/40001
5 years, 7 months ago (2015-05-26 07:07:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-26 07:54:19 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 07:54:30 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85a0542df592cc297f52f00e00d74ada1206efdf
Cr-Commit-Position: refs/heads/master@{#28610}

Powered by Google App Engine
This is Rietveld 408576698