Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 115673002: Fix linux/gcc compiler warnings in tools/ipc_fuzzer. (Closed)

Created:
7 years ago by Tom Sepez
Modified:
7 years ago
Reviewers:
aedla
CC:
chromium-reviews
Visibility:
Public.

Description

Fix linux/gcc compiler warnings in tools/ipc_fuzzer. It's really sad when your ASCII art breaks the compilation, but ending a //-style comment line with a \ means the comment continues and this is flagged as a bad thing (tm). The other change is a signed/unsigned comparison, which is OK because it is range checked prior to casting. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/ipc_fuzzer/message_lib/message_file_format.h View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Tom Sepez
Juri, please review.
7 years ago (2013-12-14 00:40:20 UTC) #1
aedla
On 2013/12/14 00:40:20, Tom Sepez wrote: > Juri, please review. LGTM, thanks.
7 years ago (2013-12-14 14:40:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/115673002/1
7 years ago (2013-12-16 17:54:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204968
7 years ago (2013-12-16 19:18:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/115673002/1
7 years ago (2013-12-16 19:33:17 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205139
7 years ago (2013-12-16 22:43:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/115673002/1
7 years ago (2013-12-16 22:54:08 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-17 02:18:42 UTC) #8
Message was sent while issue was closed.
Change committed as 241109

Powered by Google App Engine
This is Rietveld 408576698