content/public/android/java/src/org/chromium/content/browser/ContentView.java - Issue 11567061: Throw exception when initialization failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 11567061: Throw exception when initialization failed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove process initialization in ContentViewCore constructor Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/app/LibraryLoader.java ('K') | « content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | content/public/common/result_codes.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

index 27b937a39f6754ca0b3d25d89fe6565cd1cb1197..0bb27dc170f85bf948bc527ef963d4d321b21992 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

@@ -21,6 +21,7 @@ import android.view.inputmethod.EditorInfo;

import android.view.inputmethod.InputConnection;

import android.widget.FrameLayout;

+import org.chromium.content.common.ProcessInitException;

import org.chromium.content.common.TraceEvent;

import org.chromium.ui.gfx.NativeWindow;

@@ -69,7 +70,8 @@ public class ContentView extends FrameLayout implements ContentViewCore.Internal

* maximum number of allowed renderers is capped by MAX_RENDERERS_LIMIT.

* @return Whether the process actually needed to be initialized (false if already running).

- public static boolean enableMultiProcess(Context context, int maxRendererProcesses) {

+ public static boolean enableMultiProcess(Context context, int maxRendererProcesses)

+ throws ProcessInitException {

return ContentViewCore.enableMultiProcess(context, maxRendererProcesses);

}

@@ -81,7 +83,8 @@ public class ContentView extends FrameLayout implements ContentViewCore.Internal

* @param maxRendererProcesses Same as ContentView.enableMultiProcess()

* @return Whether the process actually needed to be initialized (false if already running).

- public static boolean initChromiumBrowserProcess(Context context, int maxRendererProcesses) {

+ public static boolean initChromiumBrowserProcess(Context context, int maxRendererProcesses)

+ throws ProcessInitException {

return ContentViewCore.initChromiumBrowserProcess(context, maxRendererProcesses);

}