content/shell/android/java/src/org/chromium/content_shell/Shell.java - Issue 11567061: Throw exception when initialization failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/Shell.java

Issue 11567061: Throw exception when initialization failed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/result_codes.h ('K') | « content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java ('k') | testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/java/src/org/chromium/content_shell/Shell.java

diff --git a/content/shell/android/java/src/org/chromium/content_shell/Shell.java b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

index 31c66c936fe9e2490dcddf536763b31109fd9724..75ce8a370c8a5af8760d3f96bd44c0e8f1ff64d5 100644

--- a/content/shell/android/java/src/org/chromium/content_shell/Shell.java

+++ b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

@@ -24,6 +24,7 @@ import org.chromium.base.JNINamespace;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewRenderView;

import org.chromium.content.browser.LoadUrlParams;

+import org.chromium.content.common.ProcessInitException;

import org.chromium.ui.gfx.NativeWindow;

/**

@@ -212,7 +213,7 @@ public class Shell extends LinearLayout {

@SuppressWarnings("unused")

@CalledByNative

- private void initFromNativeTabContents(int nativeTabContents) {

+ private void initFromNativeTabContents(int nativeTabContents) throws ProcessInitException {

mContentView = ContentView.newInstance(

getContext(), nativeTabContents, mWindow, ContentView.PERSONALITY_CHROME);

if (mContentView.getUrl() != null) mUrlTextView.setText(mContentView.getUrl());