Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java

Issue 11567061: Throw exception when initialization failed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java
diff --git a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java
index 2f6a51b9e5a94607a617e48e25777e7d6e8211c6..ecc56b2bcb7e33064e243e908a65cfdc307c17d8 100644
--- a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java
+++ b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.testshell;
import android.util.AttributeSet;
+import android.util.Log;
import android.view.ViewGroup;
import android.content.Context;
import android.widget.FrameLayout;
@@ -12,6 +13,7 @@ import android.widget.LinearLayout;
import org.chromium.chrome.browser.TabBase;
import org.chromium.content.browser.ContentViewRenderView;
+import org.chromium.content.common.ProcessInitException;
import org.chromium.ui.gfx.NativeWindow;
/**
@@ -84,9 +86,12 @@ public class TabManager extends LinearLayout {
*/
public void createTab(String url) {
if (!isContentViewRenderViewInitialized()) return;
-
- TabBase tab = new TabBase(getContext(), url, mWindow);
- setCurrentTab(tab);
+ try {
+ TabBase tab = new TabBase(getContext(), url, mWindow);
+ setCurrentTab(tab);
+ } catch (ProcessInitException e) {
+ throw new Error(e);
+ }
}
private boolean isContentViewRenderViewInitialized() {
@@ -106,4 +111,4 @@ public class TabManager extends LinearLayout {
mContentViewRenderView.setCurrentContentView(mCurrentTab.getContentView());
mCurrentTab.getContentView().requestFocus();
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698