Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 11567061: Throw exception when initialization failed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 27038d6798e536d1ea791b897a76ef8b924ee27e..c5ba3c4938ba5d49832a13f39dbddc6c34be9aa5 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -32,6 +32,7 @@ import org.chromium.content.browser.LoadUrlParams;
import org.chromium.content.browser.NavigationHistory;
import org.chromium.content.browser.PageTransitionTypes;
import org.chromium.content.common.CleanupReference;
+import org.chromium.content.common.ProcessInitException;
import org.chromium.content.components.navigation_interception.InterceptNavigationDelegate;
import org.chromium.net.X509Util;
import org.chromium.ui.gfx.NativeWindow;
@@ -274,7 +275,8 @@ public class AwContents {
ContentViewCore.InternalAccessDelegate internalAccessAdapter,
AwContentsClient contentsClient,
NativeWindow nativeWindow, boolean privateBrowsing,
- boolean isAccessFromFileURLsGrantedByDefault) {
+ boolean isAccessFromFileURLsGrantedByDefault)
+ throws ProcessInitException {
mContainerView = containerView;
mInternalAccessAdapter = internalAccessAdapter;
// Note that ContentViewCore must be set up before AwContents, as ContentViewCore
@@ -430,13 +432,15 @@ public class AwContents {
* Called on the "source" AwContents that is opening the popup window to
* provide the AwContents to host the pop up content.
*/
- public void supplyContentsForPopup(AwContents newContents) {
+ public void supplyContentsForPopup(AwContents newContents)
+ throws ProcessInitException {
int popupWebContents = nativeReleasePopupWebContents(mNativeAwContents);
assert popupWebContents != 0;
newContents.setNewWebContents(popupWebContents);
}
- private void setNewWebContents(int newWebContentsPtr) {
+ private void setNewWebContents(int newWebContentsPtr)
+ throws ProcessInitException {
// When setting a new WebContents, we new up a ContentViewCore that will
// wrap it and then swap it.
ContentViewCore newCore = new ContentViewCore(mContainerView.getContext(),

Powered by Google App Engine
This is Rietveld 408576698