mac: Handle hidpi cursors.

mac: Handle hidpi cursors.

Also remove some more 10.5 code.

BUG=161613
TEST=/Users/thakis/Downloads/cursors/cursor-imgset.html
TBR=tony

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173258

[Avi (use Gerrit), 2012-12-14 21:46:26]

https://codereview.chromium.org/11567049/diff/2001/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/11567049/diff/2001/skia/ext/skia_utils_mac.mm...
skia/ext/skia_utils_mac.mm:240:
SkBitmapToNSBitmapImageRepWithColorSpace(skiaBitmap, colorSpace)];
Nice change, but I'm not sure how it relates to cursors.

https://codereview.chromium.org/11567049/diff/2001/webkit/glue/webcursor_mac.mm
File webkit/glue/webcursor_mac.mm (left):

https://codereview.chromium.org/11567049/diff/2001/webkit/glue/webcursor_mac....
webkit/glue/webcursor_mac.mm:304: return LoadCursor(IDR_CONTEXTMENU_CURSOR, 3,
2);
Are we dropping the bundling of the bitmaps we no longer need?

[Nico, 2012-12-14 21:49:37]

https://codereview.chromium.org/11567049/diff/2001/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/11567049/diff/2001/skia/ext/skia_utils_mac.mm...
skia/ext/skia_utils_mac.mm:240:
SkBitmapToNSBitmapImageRepWithColorSpace(skiaBitmap, colorSpace)];
On 2012/12/14 21:46:26, Avi wrote:
> Nice change, but I'm not sure how it relates to cursors.

I was reading this file while working on this change. It's not related; if you
want I can move this to a separate CL.

https://codereview.chromium.org/11567049/diff/2001/webkit/glue/webcursor_mac.mm
File webkit/glue/webcursor_mac.mm (left):

https://codereview.chromium.org/11567049/diff/2001/webkit/glue/webcursor_mac....
webkit/glue/webcursor_mac.mm:304: return LoadCursor(IDR_CONTEXTMENU_CURSOR, 3,
2);
On 2012/12/14 21:46:26, Avi wrote:
> Are we dropping the bundling of the bitmaps we no longer need?

Good question! It looks like IDR_CONTEXTMENU_CURSOR was only used here, so it
can be removed. However, it's defined in webkit, so I'll delete it there once
this CL here has landed.

[Avi (use Gerrit), 2012-12-14 21:52:15]

LGTM

https://codereview.chromium.org/11567049/diff/2001/webkit/glue/webcursor_mac.mm
File webkit/glue/webcursor_mac.mm (left):

https://codereview.chromium.org/11567049/diff/2001/webkit/glue/webcursor_mac....
webkit/glue/webcursor_mac.mm:321: return LoadCursor(IDR_COPY_CURSOR, 3, 2);
And IDR_COPY_CURSOR too.

[commit-bot: I haz the power, 2012-12-14 21:53:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/11567049/2001

[commit-bot: I haz the power, 2012-12-14 21:53:33]

Presubmit check for 11567049-2001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit

Presubmit checks took 1.0s to calculate.

[Nico, 2012-12-14 22:11:13]

+tony for webkit/OWNERS

[commit-bot: I haz the power, 2012-12-14 22:13:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/11567049/2001

[tony, 2012-12-14 22:22:08]

webkit LGTM