Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: ui/gfx/transform.h

Issue 11567034: Changes subtreeShouldRenderToSeparateSurface logic to account for explicit clipping (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moving IsPositiveScaleOrTranslation into gfx::Transform Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« cc/layer_tree_host_common.cc ('K') | « cc/texture_layer_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GFX_TRANSFORM_H_ 5 #ifndef UI_GFX_TRANSFORM_H_
6 #define UI_GFX_TRANSFORM_H_ 6 #define UI_GFX_TRANSFORM_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "third_party/skia/include/utils/SkMatrix44.h" 9 #include "third_party/skia/include/utils/SkMatrix44.h"
10 #include "ui/base/ui_export.h" 10 #include "ui/base/ui_export.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 void ConcatTransform(const Transform& transform); 71 void ConcatTransform(const Transform& transform);
72 72
73 // Returns true if this is the identity matrix. 73 // Returns true if this is the identity matrix.
74 bool IsIdentity() const { return matrix_.isIdentity(); } 74 bool IsIdentity() const { return matrix_.isIdentity(); }
75 75
76 // Returns true if the matrix is either identity or pure translation. 76 // Returns true if the matrix is either identity or pure translation.
77 bool IsIdentityOrTranslation() const { 77 bool IsIdentityOrTranslation() const {
78 return !(matrix_.getType() & ~SkMatrix44::kTranslate_Mask); 78 return !(matrix_.getType() & ~SkMatrix44::kTranslate_Mask);
79 } 79 }
80 80
81 // Returns trus if the matrix is either a scale and/or translation
82 bool IsPositiveScaleOrTranslation() const {
danakj 2012/12/15 18:49:12 Could you add a unit test in ui/gfx/transform_unit
83 if (!IsScaleOrTranslation())
84 return false;
85 return matrix_.getDouble(0, 0) > 0.0 &&
86 matrix_.getDouble(1, 1) > 0.0 &&
87 matrix_.getDouble(2, 2) > 0.0;
88 }
89
81 // Returns true if the matrix is either identity or pure, non-fractional 90 // Returns true if the matrix is either identity or pure, non-fractional
82 // translation. 91 // translation.
83 bool IsIdentityOrIntegerTranslation() const; 92 bool IsIdentityOrIntegerTranslation() const;
84 93
85 // Returns true if the matrix is has only scaling and translation components. 94 // Returns true if the matrix is has only scaling and translation components.
86 bool IsScaleOrTranslation() const; 95 bool IsScaleOrTranslation() const;
87 96
88 // Returns true if the matrix has any perspective component that would 97 // Returns true if the matrix has any perspective component that would
89 // change the w-component of a homogeneous point. 98 // change the w-component of a homogeneous point.
90 bool HasPerspective() const; 99 bool HasPerspective() const;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 Point3F& point) const; 169 Point3F& point) const;
161 170
162 SkMatrix44 matrix_; 171 SkMatrix44 matrix_;
163 172
164 // copy/assign are allowed. 173 // copy/assign are allowed.
165 }; 174 };
166 175
167 } // namespace gfx 176 } // namespace gfx
168 177
169 #endif // UI_GFX_TRANSFORM_H_ 178 #endif // UI_GFX_TRANSFORM_H_
OLDNEW
« cc/layer_tree_host_common.cc ('K') | « cc/texture_layer_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698