[net/dns] Handle TC bit on DNS response in DnsTransaction.

net/dns/dns_response.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DNS_DNS_RESPONSE_H_
 #define NET_DNS_DNS_RESPONSE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 77 matching lines @@
     DNS_NAME_MISMATCH,         // Got an address but no ordered chain of CNAMEs
                                // leads there.
     DNS_SIZE_MISMATCH,         // Got an address but size does not match.
     DNS_CNAME_AFTER_ADDRESS,   // Found CNAME after an address record.
     DNS_ADDRESS_TTL_MISMATCH,  // OBSOLETE. No longer used.
     DNS_NO_ADDRESSES,          // OBSOLETE. No longer used.
     // Only add new values here.
     DNS_PARSE_RESULT_MAX,      // Bounding value for histograms.
   };
 
-  // Constructs an object with an IOBuffer large enough to read
-  // one byte more than largest possible response, to detect malformed
-  // responses.
+  // Constructs a response buffer large enough to store one byte more than
+  // largest possible response, to detect malformed responses.
   DnsResponse();
+  // Construct a response buffer of given length. Used for TCP transactions.

[mmenke, 2012/12/19 16:44:09]

nit:  For consistency, should start all constructor comments with same form of
"Construct".

[szym, 2012/12/19 23:35:56]

Done.

+  explicit DnsResponse(size_t length);
   // Constructs response from |data|. Used for testing purposes only!
   DnsResponse(const void* data, size_t length, size_t answer_offset);
   ~DnsResponse();
 
   // Internal buffer accessor into which actual bytes of response will be
   // read.
   IOBufferWithSize* io_buffer() { return io_buffer_.get(); }
 
-  // Returns false if the packet is shorter than the header or does not match
-  // |query| id or question.
+  // Assuming the internal buffer holds |nbytes| bytes, returns true iff the
+  // packet matches the |query| id and question.
   bool InitParse(int nbytes, const DnsQuery& query);
 
   // Returns true if response is valid, that is, after successful InitParse.
   bool IsValid() const;
 
   // All of the methods below are valid only if the response is valid.
 
   // Accessors for the header.
   uint16 flags() const;  // excluding rcode
   uint8 rcode() const;
@@ skipping 25 matching lines @@
   // Iterator constructed after InitParse positioned at the answer section.
   // It is never updated afterwards, so can be used in accessors.
   DnsRecordParser parser_;
 
   DISALLOW_COPY_AND_ASSIGN(DnsResponse);
 };
 
 }  // namespace net
 
 #endif  // NET_DNS_DNS_RESPONSE_H_