Fix PPAPI time conversion code to handle epoch times.

Fix PPAPI time conversion code to handle epoch times.

This fixes the time conversion code to be able to correctly handle epoch times
(e.g. when passing a PP_Time of 0). This eliminates the need to special-case
for epoch time in other code. In practice the problem this fixes only
manifests itself in test code.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173516

[Scott Hess - ex-Googler, 2012-12-13 18:35:24]

drive-by review: much better than what went before.

https://codereview.chromium.org/11567013/diff/1/ppapi/shared_impl/time_conver...
File ppapi/shared_impl/time_conversion_unittest.cc (right):

https://codereview.chromium.org/11567013/diff/1/ppapi/shared_impl/time_conver...
ppapi/shared_impl/time_conversion_unittest.cc:64: EXPECT_GE(kTimeSecondsSlop,
fabs(converted_one_second_from_epoch - 1));
I think you should have a straight up test that PPTimeToTime(0.0) returns
UnixEpoch(), or relate an offset from the epoch in seconds between PPTime and
Time, something like:
  EXPECT_EQ(PPTimeToTime(0.0) + FromSeconds(1), PPTimeToTime(1.0));

[brettw, 2012-12-13 20:56:40]

lgtm

[raymes, 2012-12-14 17:28:22]

https://codereview.chromium.org/11567013/diff/1/ppapi/shared_impl/time_conver...
File ppapi/shared_impl/time_conversion_unittest.cc (right):

https://codereview.chromium.org/11567013/diff/1/ppapi/shared_impl/time_conver...
ppapi/shared_impl/time_conversion_unittest.cc:64: EXPECT_GE(kTimeSecondsSlop,
fabs(converted_one_second_from_epoch - 1));
On 2012/12/13 18:35:24, shess wrote:
> I think you should have a straight up test that PPTimeToTime(0.0) returns
> UnixEpoch(), or relate an offset from the epoch in seconds between PPTime and
> Time, something like:
>   EXPECT_EQ(PPTimeToTime(0.0) + FromSeconds(1), PPTimeToTime(1.0));

Done.

[commit-bot: I haz the power, 2012-12-14 17:30:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11567013/2003

[commit-bot: I haz the power, 2012-12-14 21:53:12]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-16 23:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11567013/2003