Issue 11567007: Cleanup object printer declaration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11567007: Cleanup object printer declaration. (Closed)

Created:
8 years ago by Michael Starzinger

Modified:
8 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup object printer declaration. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13214

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Sven Panne. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -292 lines)			Patch
	M	src/objects.h	View	1	50 chunks	+87 lines, -292 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years ago (2012-12-13 10:05:11 UTC) #1

LGTM with a nit

https://codereview.chromium.org/11567007/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/11567007/diff/1/src/objects.h#newcode761
src/objects.h:761: inline void Name##Print() { Name##Print(stdout); }  \
Drop this...

https://codereview.chromium.org/11567007/diff/1/src/objects.h#newcode762
src/objects.h:762: void Name##Print(FILE* out);
... and use "FILE* out = stdout" here, it's cleaner! ;-)

Expand Messages | Collapse Messages