Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1156693003: Introduce a maybe-version of Function::New (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
vogelheim
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a maybe-version of Function::New Internally, it invokes GetFunction() which returns a MaybeLocal<> BUG=4134 R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/c52bb1f03aa146aa68265489aa3411c853afb78a Cr-Commit-Position: refs/heads/master@{#28600}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M include/v8.h View 1 chunk +8 lines, -4 lines 2 comments Download
M src/api.cc View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-22 13:15:24 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/1156693003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1156693003/diff/1/include/v8.h#newcode3063 include/v8.h:3063: static V8_DEPRECATE_SOON( Why is the 'static' outside of ...
5 years, 7 months ago (2015-05-22 15:19:51 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1156693003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1156693003/diff/1/include/v8.h#newcode3063 include/v8.h:3063: static V8_DEPRECATE_SOON( On 2015/05/22 at 15:19:51, vogelheim wrote: > ...
5 years, 7 months ago (2015-05-22 18:10:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156693003/1
5 years, 7 months ago (2015-05-22 18:10:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 18:39:47 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 18:40:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c52bb1f03aa146aa68265489aa3411c853afb78a
Cr-Commit-Position: refs/heads/master@{#28600}

Powered by Google App Engine
This is Rietveld 408576698