Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1156663009: [test] Fix assert for predictable mode in test runner. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix assert for predictable mode in test runner. NOTRY=true Committed: https://crrev.com/5effc7131aa084ee8c3542e7a5b133300be6b43d Cr-Commit-Position: refs/heads/master@{#28679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/testrunner/local/execution.py View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL. One other tiny corner case for total==0.
5 years, 6 months ago (2015-05-28 12:53:14 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-05-28 12:54:58 UTC) #3
Michael Achenbach
FYI: Is broken here now: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20predictable/builds/2105
5 years, 6 months ago (2015-05-28 12:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156663009/1
5 years, 6 months ago (2015-05-28 13:05:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 13:06:39 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 13:06:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5effc7131aa084ee8c3542e7a5b133300be6b43d
Cr-Commit-Position: refs/heads/master@{#28679}

Powered by Google App Engine
This is Rietveld 408576698