Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1156663005: scheduleArchiveLoad should return false if archived resource is not available. (Closed)

Created:
5 years, 7 months ago by pals
Modified:
5 years, 6 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

scheduleArchiveLoad should return false if archived resource is not available. scheduleArchiveLoad should return false if archived resource is not available in the archive. BUG=492041 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196665

Patch Set 1 #

Patch Set 2 : Adding test #

Patch Set 3 : Uploading .mht file as binary file #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A LayoutTests/mhtml/resource_not_in_archive.mht View 1 2 3 4 Binary file 0 comments Download
A LayoutTests/mhtml/resource_not_in_archive-expected.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 37 (21 generated)
pals
PTAL.
5 years, 7 months ago (2015-05-26 06:05:33 UTC) #2
pals
On 2015/05/26 06:05:33, pals wrote: > PTAL. In desktop chrome, the save page feature does ...
5 years, 7 months ago (2015-05-26 06:20:48 UTC) #3
pals
Please review.
5 years, 6 months ago (2015-06-01 03:54:29 UTC) #5
Mike West
Does this produce a web-visible change in behavior? If so, we need a test.
5 years, 6 months ago (2015-06-01 05:45:21 UTC) #6
pals
On 2015/06/01 05:45:21, Mike West wrote: > Does this produce a web-visible change in behavior? ...
5 years, 6 months ago (2015-06-01 06:18:24 UTC) #7
pals
On 2015/06/01 06:18:24, pals wrote: > On 2015/06/01 05:45:21, Mike West wrote: > > Does ...
5 years, 6 months ago (2015-06-01 06:28:40 UTC) #8
Mike West
On 2015/06/01 at 06:28:40, sanjoy.pal wrote: > On 2015/06/01 06:18:24, pals wrote: > > On ...
5 years, 6 months ago (2015-06-01 11:51:42 UTC) #9
pals
I have added a layout test. PTAL.
5 years, 6 months ago (2015-06-02 04:55:28 UTC) #10
Mike West
Thanks for adding the test, LGTM.
5 years, 6 months ago (2015-06-02 06:56:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156663005/20001
5 years, 6 months ago (2015-06-02 07:08:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64380)
5 years, 6 months ago (2015-06-02 09:13:07 UTC) #15
pals
@samahto I think this is failing due to same problem descibed here https://codereview.chromium.org/1027623003. I am ...
5 years, 6 months ago (2015-06-02 11:36:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156663005/320001
5 years, 6 months ago (2015-06-08 06:59:54 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65614)
5 years, 6 months ago (2015-06-08 09:15:59 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156663005/320001
5 years, 6 months ago (2015-06-08 10:06:40 UTC) #36
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 11:08:08 UTC) #37
Message was sent while issue was closed.
Committed patchset #5 (id:320001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196665

Powered by Google App Engine
This is Rietveld 408576698