Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1156643007: media: Simplify {Audio|Video}Decoder initialization callback. (Closed)

Created:
5 years, 6 months ago by xhwang
Modified:
5 years, 6 months ago
Reviewers:
*watk, DaleCurtis
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Simplify {Audio|Video}Decoder initialization callback. Use base::Callback<void(bool)> instead of a PipelineStatusCB for decoder initialization where PipelineStatus is not really relevant. This helps clean up unnecessary uses of PipelineStatusCB so in the future we could plumb more info in PipelineStatusCB (e.g. error messages) to help debugging/testing. TBR=bbudge@chromium.org BUG=126070 TEST=Updated unittests. Committed: https://crrev.com/cb8f0c2260d44d6610a4c157b70c01cda1f50913 Cr-Commit-Position: refs/heads/master@{#333127}

Patch Set 1 #

Patch Set 2 : rebase only #

Patch Set 3 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -207 lines) Patch
M content/renderer/pepper/video_decoder_shim.cc View 1 2 3 chunks +4 lines, -16 lines 0 comments Download
M media/base/audio_decoder.h View 2 chunks +7 lines, -4 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +6 lines, -5 lines 0 comments Download
M media/base/test_helpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/test_helpers.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M media/base/video_decoder.h View 3 chunks +8 lines, -5 lines 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 7 chunks +9 lines, -18 lines 0 comments Download
M media/filters/audio_decoder_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M media/filters/decoder_selector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/decoder_selector.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M media/filters/decoder_stream.h View 3 chunks +4 lines, -2 lines 0 comments Download
M media/filters/decoder_stream.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decoder_stream_traits.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/decoder_stream_traits.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/decrypting_audio_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 8 chunks +13 lines, -18 lines 0 comments Download
M media/filters/fake_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/fake_video_decoder_unittest.cc View 1 2 4 chunks +7 lines, -9 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 2 11 chunks +14 lines, -16 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M media/filters/opus_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/opus_audio_decoder.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
xhwang
rebase only
5 years, 6 months ago (2015-06-03 18:14:40 UTC) #1
xhwang
watk: Please review everything. dalecurtis: Please review from a high level perspective.
5 years, 6 months ago (2015-06-03 21:01:56 UTC) #4
DaleCurtis
eyes glazed over a bit reading this, but lgtm :)
5 years, 6 months ago (2015-06-04 01:03:42 UTC) #5
xhwang
rebase only
5 years, 6 months ago (2015-06-05 17:24:38 UTC) #6
watk
lgtm!
5 years, 6 months ago (2015-06-05 19:49:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156643007/40001
5 years, 6 months ago (2015-06-05 19:52:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/68806)
5 years, 6 months ago (2015-06-05 20:03:13 UTC) #12
xhwang
TBRing bbudge@chromium.org for content/renderer/pepper/video_decoder_shim.cc change which is trivial.
5 years, 6 months ago (2015-06-05 20:08:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156643007/40001
5 years, 6 months ago (2015-06-05 20:08:37 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 20:52:20 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/cb8f0c2260d44d6610a4c157b70c01cda1f50913 Cr-Commit-Position: refs/heads/master@{#333127}
5 years, 6 months ago (2015-06-05 20:54:03 UTC) #17
Nicolas Zea
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1146913008/ by zea@chromium.org. ...
5 years, 6 months ago (2015-06-05 21:27:31 UTC) #18
xhwang
5 years, 6 months ago (2015-06-05 21:48:38 UTC) #19
Message was sent while issue was closed.
On 2015/06/05 21:27:31, Nicolas Zea wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1146913008/ by mailto:zea@chromium.org.
> 
> The reason for reverting is: Compile failure on mac:
> http://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=3225.

Thanks for the revert. I'll fix it and reland...

Powered by Google App Engine
This is Rietveld 408576698