Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: net/tools/quic/quic_dispatcher.cc

Issue 1156623003: Miscellaneous improvements to comments and formatting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fix_TSAN_problem_93901684
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/tools/quic/quic_dispatcher.h" 5 #include "net/tools/quic/quic_dispatcher.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/debug/stack_trace.h" 9 #include "base/debug/stack_trace.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 DVLOG(1) << QuicUtils::ErrorToString(error); 74 DVLOG(1) << QuicUtils::ErrorToString(error);
75 } 75 }
76 76
77 bool OnProtocolVersionMismatch(QuicVersion /*received_version*/) override { 77 bool OnProtocolVersionMismatch(QuicVersion /*received_version*/) override {
78 DVLOG(1) << "Version mismatch, connection ID " << connection_id_; 78 DVLOG(1) << "Version mismatch, connection ID " << connection_id_;
79 // Keep processing after protocol mismatch - this will be dealt with by the 79 // Keep processing after protocol mismatch - this will be dealt with by the
80 // time wait list or connection that we will create. 80 // time wait list or connection that we will create.
81 return true; 81 return true;
82 } 82 }
83 83
84 // The following methods should never get called because we always return 84 // The following methods should never get called because
85 // false from OnUnauthenticatedHeader(). As a result, we never process the 85 // OnUnauthenticatedPublicHeader() or OnUnauthenticatedHeader() (whichever was
86 // payload of the packet. 86 // called last), will return false and prevent a subsequent invocation of
87 // these methods. Thus, the payload of the packet is never processed in the
88 // dispatcher.
87 void OnPublicResetPacket(const QuicPublicResetPacket& /*packet*/) override { 89 void OnPublicResetPacket(const QuicPublicResetPacket& /*packet*/) override {
88 DCHECK(false); 90 DCHECK(false);
89 } 91 }
90 void OnVersionNegotiationPacket( 92 void OnVersionNegotiationPacket(
91 const QuicVersionNegotiationPacket& /*packet*/) override { 93 const QuicVersionNegotiationPacket& /*packet*/) override {
92 DCHECK(false); 94 DCHECK(false);
93 } 95 }
94 void OnDecryptedPacket(EncryptionLevel level) override { DCHECK(false); } 96 void OnDecryptedPacket(EncryptionLevel level) override { DCHECK(false); }
95 bool OnPacketHeader(const QuicPacketHeader& /*header*/) override { 97 bool OnPacketHeader(const QuicPacketHeader& /*header*/) override {
96 DCHECK(false); 98 DCHECK(false);
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 // send it to the time wait manager in OnUnathenticatedHeader. 502 // send it to the time wait manager in OnUnathenticatedHeader.
501 return true; 503 return true;
502 } 504 }
503 505
504 void QuicDispatcher::SetLastError(QuicErrorCode error) { 506 void QuicDispatcher::SetLastError(QuicErrorCode error) {
505 last_error_ = error; 507 last_error_ = error;
506 } 508 }
507 509
508 } // namespace tools 510 } // namespace tools
509 } // namespace net 511 } // namespace net
OLDNEW
« no previous file with comments | « net/tools/quic/quic_dispatcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698