Increase default maximum desktop size and make it configurable.

remoting/tools/me2me_virtual_host.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Virtual Me2Me implementation.  This script runs and manages the processes
 # required for a Virtual Me2Me desktop, which are: X server, X desktop
 # session, and Host process.
 # This script is intended to run continuously as a background daemon
 # process, running under an ordinary (non-root) user account.
@@ skipping 16 matching lines @@
 
 # By default this script will try to determine the most appropriate X session
 # command for the system.  To use a specific session instead, set this variable
 # to the executable filename, or a list containing the executable and any
 # arguments, for example:
 # XSESSION_COMMAND = "/usr/bin/gnome-session-fallback"
 # XSESSION_COMMAND = ["/usr/bin/gnome-session", "--session=ubuntu-2d"]
 XSESSION_COMMAND = None
 
 LOG_FILE_ENV_VAR = "CHROME_REMOTE_DESKTOP_LOG_FILE"
+MAXIMUM_SIZE_ENV_VAR = "CHROME_REMOTE_DESKTOP_MAXIMUM_DESTOP_SIZE"

[Wez, 2012/12/14 19:07:00]

typo: DESTOP

[Jamie, 2012/12/14 19:29:16]

Done.

 
 SCRIPT_PATH = sys.path[0]
 
 DEFAULT_INSTALL_PATH = "/opt/google/chrome-remote-desktop"
 if SCRIPT_PATH == DEFAULT_INSTALL_PATH:
   HOST_BINARY_NAME = "chrome-remote-desktop-host"
 else:
   HOST_BINARY_NAME = "remoting_me2me_host"
 
 CHROME_REMOTING_GROUP_NAME = "chrome-remote-desktop"
@@ skipping 694 matching lines @@
           raise
         elif deadline > now:
           time.sleep(deadline - now)
         return (0, 0)
       else:
         # Anything else is an unexpected error.
         raise
 
 
 def main():
-  DEFAULT_SIZE = "2560x1600"
+  DEFAULT_SIZE = "3840x1600"

[Wez, 2012/12/14 19:07:00]

This is an insane default size, e.g. if the user connects with resize-to-client
disabled; why not set MAXIMUM_SIZE to this, or to the size the user specifies,
and have a separate default size?

[Jamie, 2012/12/14 19:29:16]

We don't have a MAXIMUM_SIZE variable--it's computed from the -s options
specified on the command-line. This is just the value that's used if no -s
options are specified on the command-line. How about having an environment
variable that can specify multiple default sizes, and having that default to,
say, 1600x1200,3840x1600? I think that should work in both the resize and
non-resize cases.

[Wez, 2012/12/14 19:30:13]

SGTM :)

[Jamie, 2012/12/14 19:42:58]

Done.

+  if os.environ.has_key(MAXIMUM_SIZE_ENV_VAR):
+    DEFAULT_SIZE = os.environ[MAXIMUM_SIZE_ENV_VAR]
   EPILOG = """This script is not intended for use by end-users.  To configure
 Chrome Remote Desktop, please install the app from the Chrome
 Web Store: https://chrome.google.com/remotedesktop"""
   parser = optparse.OptionParser(
       usage="Usage: %prog [options] [ -- [ X server options ] ]",
       epilog=EPILOG)
   parser.add_option("-s", "--size", dest="size", action="append",
                     help="Dimensions of virtual desktop (default: %s). "
                     "This can be specified multiple times to make multiple "
                     "screen resolutions available (if the Xvfb server "
@@ skipping 275 matching lines @@
         host_config.clear_auth()
         host_config.clear_host_info()
         host_config.save()
         return 0
 
 
 if __name__ == "__main__":
   logging.basicConfig(level=logging.DEBUG,
                       format="%(asctime)s:%(levelname)s:%(message)s")
   sys.exit(main())