Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: test/mjsunit/harmony/object-observe.js

Issue 11566027: Object.oberve: assertions to narrow down flaky crashes with array length mutation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comment Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 925 matching lines...) Expand 10 before | Expand all | Expand 10 after
936 var count = oldSize > newSize ? oldSize - newSize : 0; 936 var count = oldSize > newSize ? oldSize - newSize : 0;
937 observer.assertRecordCount(count + 1); 937 observer.assertRecordCount(count + 1);
938 var lengthRecord = observer.records[count]; 938 var lengthRecord = observer.records[count];
939 assertSame(arr, lengthRecord.object); 939 assertSame(arr, lengthRecord.object);
940 assertEquals('length', lengthRecord.name); 940 assertEquals('length', lengthRecord.name);
941 assertEquals('updated', lengthRecord.type); 941 assertEquals('updated', lengthRecord.type);
942 assertSame(oldSize, lengthRecord.oldValue); 942 assertSame(oldSize, lengthRecord.oldValue);
943 } 943 }
944 } 944 }
945 945
946 // TODO(rossberg): Still flaky on buildbots, disable for now...
947 /*
948 for (var b1 = 0; b1 < 2; ++b1) 946 for (var b1 = 0; b1 < 2; ++b1)
949 for (var b2 = 0; b2 < 2; ++b2) 947 for (var b2 = 0; b2 < 2; ++b2)
950 for (var n1 = 0; n1 < 3; ++n1) 948 for (var n1 = 0; n1 < 3; ++n1)
951 for (var n2 = 0; n2 < 3; ++n2) 949 for (var n2 = 0; n2 < 3; ++n2)
952 TestFastElementsLength(b1 != 0, b2 != 0, 20*n1, 20*n2); 950 TestFastElementsLength(b1 != 0, b2 != 0, 20*n1, 20*n2);
953 */
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698