Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 11566017: Use --strip-debug on pnacl_irt_shim archive to reduce size of chrome bundle. (Closed)

Created:
8 years ago by jvoung (off chromium)
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use --strip-debug on pnacl_irt_shim archive to reduce size of chrome bundle. Debugging nexes from pexes, could be done offline anyway. Depends on: https://codereview.chromium.org/11576019/ to actually have an effect. Otherwise the flag is ignored. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173737

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvoung (off chromium)
brad, do you no more about restricting this to Release 'configurations', when build_nexe is involved?
8 years ago (2012-12-14 22:20:41 UTC) #1
bradn
Release vs debug in gyp is very limited. There are ways, but would buildtype=dev vs ...
8 years ago (2012-12-14 22:24:11 UTC) #2
Derek Schuff
On 2012/12/14 22:24:11, bradn wrote: > Release vs debug in gyp is very limited. > ...
8 years ago (2012-12-14 22:29:19 UTC) #3
jvoung (off chromium)
On 2012/12/14 22:29:19, Derek Schuff wrote: > On 2012/12/14 22:24:11, bradn wrote: > > Release ...
8 years ago (2012-12-14 22:44:55 UTC) #4
bradn
Nacl's bots all do dev as do most waterfall chrome bots. On Fri, Dec 14, ...
8 years ago (2012-12-14 23:34:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/11566017/10001
8 years ago (2012-12-18 01:28:45 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-18 01:54:48 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698