Use MemoryChunk-based allocation for deoptimization entry code

src/spaces.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 635 matching lines @@
     return static_cast<int>(area_end() - area_start());
   }
 
   // Approximate amount of physical memory committed for this chunk.
   size_t CommittedPhysicalMemory() {
     return high_water_mark_;
   }
 
   static inline void UpdateHighWaterMark(Address mark);
 
+  // Commit the delta memory region from area_end_ to area_start_ + body_size,

[danno, 2013/01/17 10:49:55]

Please don't include implementation details (e.g. mentioning "area_end_ to
area_start_" in the interface comment). 

[haitao.feng, 2013/01/17 14:20:33]

Done.

+  // If body_size <= area_end_ - area_start_, this function just returns true
+  // and no uncommitment happens.

[danno, 2013/01/17 10:49:55]

s/area_end_ to area_start_/Pages are never uncommitted.

[haitao.feng, 2013/01/17 14:20:33]

Done.

+  bool CommitBody(size_t body_size, Executability executable);
+
  protected:
   MemoryChunk* next_chunk_;
   MemoryChunk* prev_chunk_;
   size_t size_;
   intptr_t flags_;
 
   // Start and end of allocatable memory on this chunk.
   Address area_start_;
   Address area_end_;
 
@@ skipping 215 matching lines @@
   bool contains(Address address) {
     if (this == NULL || code_range_ == NULL) return false;
     Address start = static_cast<Address>(code_range_->address());
     return start <= address && address < start + code_range_->size();
   }
 
   // Allocates a chunk of memory from the large-object portion of
   // the code range.  On platforms with no separate code range, should
   // not be called.
   MUST_USE_RESULT Address AllocateRawMemory(const size_t requested,
-                                            size_t* allocated);
+                                            size_t* allocated,
+                                            size_t commit_body_size);

[danno, 2013/01/17 10:49:55]

Can you make this the second parameter? Also, "body" doesn't seem right. I think
the parameters should be called "reserved_size" and "committed_size"

[haitao.feng, 2013/01/17 14:20:33]

Done.

+  bool CommitRawMemory(Address start, size_t length);
   void FreeRawMemory(Address buf, size_t length);
 
  private:
   Isolate* isolate_;
 
   // The reserved range of virtual memory that all code objects are put in.
   VirtualMemory* code_range_;
   // Plain old data class, just a struct plus a constructor.
   class FreeBlock {
    public:
@@ skipping 127 matching lines @@
   // Returns maximum available bytes that the old space can have.
   intptr_t MaxAvailable() {
     return (Available() / Page::kPageSize) * Page::kMaxNonCodeHeapObjectSize;
   }
 
 #ifdef DEBUG
   // Reports statistic info of the space.
   void ReportStatistics();
 #endif
 
-  MemoryChunk* AllocateChunk(intptr_t body_size,
+  // After calling this function, the memory region from commit_body_size to
+  // reserve_body_size of the body is reserved but not committed, they could be
+  // committed later by calling MemoryChunk::CommitBody with a new body size.
+  MemoryChunk* AllocateChunk(intptr_t reserve_body_size,
+                             intptr_t commit_body_size,
                              Executability executable,
                              Space* space);
 
   Address ReserveAlignedMemory(size_t requested,
                                size_t alignment,
                                VirtualMemory* controller);
   Address AllocateAlignedMemory(size_t requested,

[danno, 2013/01/17 10:49:55]

"requested_size" should be first parameter, second parameters should be
"commited_size"

[haitao.feng, 2013/01/17 14:20:33]

Done.

                                 size_t alignment,
+                                size_t commit_body_size,
                                 Executability executable,
                                 VirtualMemory* controller);
 
   void FreeMemory(VirtualMemory* reservation, Executability executable);
   void FreeMemory(Address addr, size_t size, Executability executable);
 
   // Commit a contiguous block of memory from the initial chunk.  Assumes that
   // the address is not NULL, the size is greater than zero, and that the
   // block is contained in the initial chunk.  Returns true if it succeeded
   // and false otherwise.
@@ skipping 30 matching lines @@
   static int CodePageAreaStartOffset();
 
   static int CodePageAreaEndOffset();
 
   static int CodePageAreaSize() {
     return CodePageAreaEndOffset() - CodePageAreaStartOffset();
   }
 
   MUST_USE_RESULT static bool CommitCodePage(VirtualMemory* vm,
                                              Address start,
-                                             size_t size);
+                                             size_t size,
+                                             size_t body_size);
 
  private:
   Isolate* isolate_;
 
   // Maximum space size in bytes.
   size_t capacity_;
   // Maximum subset of capacity_ that can be executable
   size_t capacity_executable_;
 
   // Allocated space size in bytes.
@@ skipping 1654 matching lines @@
   }
   // Must be small, since an iteration is used for lookup.
   static const int kMaxComments = 64;
 };
 #endif
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_SPACES_H_