[Sync] Break up the Android BookmarksTest cases more.

[Sync] Break up the Android BookmarksTest cases more.

This change addresses some concerns raised post-submit in my
previous CL: http://crrev.com/1151833003

BUG=480604
Committed: https://crrev.com/44547d35c987d99a26149b213cb5875caf082997
Cr-Commit-Position: refs/heads/master@{#333082}

[maxbogue, 2015-06-02 20:19:24]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org, pvalenzuela@chromium.org, zea@chromium.org

[maxbogue, 2015-06-02 20:19:27]

Hey chaps,

Here's a follow-up CL that I think should satisfy all the concerns from the
previous one. PTAL!

[Nicolas Zea, 2015-06-03 17:40:09]

One nit, else LG, leaving the main review to Patrick

https://codereview.chromium.org/1156573006/diff/20001/chrome/android/sync_she...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java
(right):

https://codereview.chromium.org/1156573006/diff/20001/chrome/android/sync_she...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java:40:
// A container to store bookmark information in for data verification.
nit: remove "in", which is already implied by "container"

[pval...(no longer on Chromium), 2015-06-04 18:36:38]

I assume this CL is blocked on committing your other re-land CL?

https://codereview.chromium.org/1156573006/diff/20001/chrome/android/sync_she...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java
(right):

https://codereview.chromium.org/1156573006/diff/20001/chrome/android/sync_she...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java:59:
mBookmarksBridge = new BookmarksBridge(Profile.getLastUsedProfile());
I know this is old code, but can you add a comment explaining why we work with
the BookmarksBridge here? AFAIK, it's so that bookmarks work in the Sync shell.

[maxbogue, 2015-06-04 20:01:14]

https://codereview.chromium.org/1156573006/diff/20001/chrome/android/sync_she...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java
(right):

https://codereview.chromium.org/1156573006/diff/20001/chrome/android/sync_she...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java:40:
// A container to store bookmark information in for data verification.
On 2015/06/03 17:40:09, Nicolas Zea wrote:
> nit: remove "in", which is already implied by "container"

Done.

https://codereview.chromium.org/1156573006/diff/20001/chrome/android/sync_she...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java:59:
mBookmarksBridge = new BookmarksBridge(Profile.getLastUsedProfile());
On 2015/06/04 18:36:38, pvalenzuela wrote:
> I know this is old code, but can you add a comment explaining why we work with
> the BookmarksBridge here? AFAIK, it's so that bookmarks work in the Sync
shell.

Done.

[maxbogue, 2015-06-04 20:01:41]

maxbogue@chromium.org changed required reviewers:
+ pvalenzuela@chromium.org

[pval...(no longer on Chromium), 2015-06-05 17:07:31]

lgtm

[maxbogue, 2015-06-05 17:23:25]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2015-06-05 17:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1156573006/40001

[commit-bot: I haz the power, 2015-06-05 17:28:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 17:29:18]

Patchset 3 (id:??) landed as
https://crrev.com/44547d35c987d99a26149b213cb5875caf082997
Cr-Commit-Position: refs/heads/master@{#333082}

[nyquist, 2015-06-05 19:08:58]

a belated lgtm